Louisvdw / dbus-serialbattery

Battery Monitor driver for serial battery in VenusOS GX systems
MIT License
543 stars 166 forks source link

Revov.py not installed by installscript via SSH on a Cerbo GX #364

Closed pmcgn closed 1 year ago

pmcgn commented 1 year ago

Describe the bug Revov.py is not downloaded/installed by the installation script via SSH. (Tried to run the installer a second time - no change)

I see the following error in /data/log/dbus-serialbattery.ttyUSB0/current :

Traceback (most recent call last): File "/opt/victronenergy/dbus-serialbattery/dbus-serialbattery.py", line 25, in from revov import Revov ModuleNotFoundError: No module named 'revov'

After downloading it manually to /opt/victronenergy/dbus-serialbattery/, the issue is resolved and I see a cuccess message in the log and the BMS appears in the UI.

I noticed that the last commit (7b239007bd87bc3fdfd6a3a3726937f1210997f2) removed the file Revov.py from another file. Didn't look more into the details - sorry.

To Reproduce Steps to reproduce the behavior:

  1. Run installation routine as described in Wiki on a Cerbo GX via SSH.
  2. Check if File /opt/victronenergy/dbus-serialbattery/Revov.py exists
  3. Check log /data/log/dbus-serialbattery.ttyUSB0/current (should indicate that the file is missing)

Expected behavior All dependencies (including Revov.py) should be available and the python script should not throw any errors.

Screenshots Error_serialbattery

VenusOS (please complete the following information):

Battery/BMS (please complete the following information):

Additional context Thanks for doing all the hard work!

NickDolfin commented 1 year ago

Same here. I get the same error. device raspberry pi 3b firmWARE 2.92 using ftdi rs485 cable https://ftdichip.com/products/usb-rs485-we-5000-bt/ a very expensive cable, but I had one lying around.... it is attached to usb3.

I had to get the file manually: root@raspberrypi2:/opt/victronenergy/dbus-serialbattery# wget https://raw.githubusercontent.com/Louisvdw/dbus-serialbattery/master/etc/dbus-serialbattery/revov.py

I just used the orange (data+ A) and yellow (Data- B) connections from the FTDI cable. No ground needed! The BMS has only two rs485 wires a red (data+A) and a black (data-B) wire plus an uart/bluetooth output. Now, I can use the bluetooth app in my phone simultaneously with the victron raspi. Nice!

BMS: https://www.lithiumbatterypcb.com/product/4s-or-3s-12v-li-ion-or-lifepo4-battery-smart-bms-with-bluetooth-function-uart-and-rs485-communication-with-60a-to-120a-constant-current/

For those who are interested have a look at Andy: https://www.youtube.com/watch?v=sHIlP2oJ3DU

Thanks Louis for the great work!

chaerle commented 1 year ago

See Pull request https://github.com/Louisvdw/dbus-serialbattery/pull/369 for fix.

Louisvdw commented 1 year ago

Fixed in new release v0.14.3