Closed Thomk-63 closed 2 years ago
Pull request #90 now add support for alarms on Daly BMS
@Thomk-63 The Daly docs do not specify how to pull configured capacity or Ah consumed although a calculated Ah consumed is placed on dbus as /ConsumedAmphours. The current code now includes a BATTERY_CAPACITY variable in utils.py to specify your battery capacity. Most Alarm data is now pulled from BMS, system failures not currently pulled.
Thanks alot for the quick implementation!
Regards, Thomas Thomas + Nicole Krüger @.***
Am 07.02.2022 um 16:55 schrieb CaptKrisp @.***>:
@Thomk-63 https://github.com/Thomk-63 The Daly docs do not specify how to pull configured capacity. The current code now includes a BATTERY_CAPACITY variable in utils.py to specify your battery capacity. Most Alarm data is now pulled from BMS.
— Reply to this email directly, view it on GitHub https://github.com/Louisvdw/dbus-serialbattery/issues/86#issuecomment-1031625493, or unsubscribe https://github.com/notifications/unsubscribe-auth/AXRCL3J3W4GAIRHKNAH4UC3UZ7TQFANCNFSM5NERMJJQ. Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. You are receiving this because you were mentioned.
Hi Louis, which files need to be updated? all?
Regards, Thomas Thomas + Nicole Krüger @.***
Am 07.02.2022 um 16:55 schrieb CaptKrisp @.***>:
@Thomk-63 https://github.com/Thomk-63 The Daly docs do not specify how to pull configured capacity. The current code now includes a BATTERY_CAPACITY variable in utils.py to specify your battery capacity. Most Alarm data is now pulled from BMS.
— Reply to this email directly, view it on GitHub https://github.com/Louisvdw/dbus-serialbattery/issues/86#issuecomment-1031625493, or unsubscribe https://github.com/notifications/unsubscribe-auth/AXRCL3J3W4GAIRHKNAH4UC3UZ7TQFANCNFSM5NERMJJQ. Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. You are receiving this because you were mentioned.
Hi Thomas I'm still busy adding more fixes and these new changes have not all been tested together so there might be some errors. If you want to give it a test before the next betais released then update from the latest main branch the following files: battery.py, dbushelper.py, daly.py and utils.py If you find any issues report it and revert to the last release again.
Thanks, I will do and will report.
Regards, Thomas Thomas + Nicole Krüger @.***
Am 07.02.2022 um 20:13 schrieb Louis Van Der Walt @.***>:
Hi Thomas I'm still busy adding more fixes and these new changes have not all been tested together so there might be some errors. If you want to give it a test before the next betais released then update from the latest main branch the following files: battery.py, dbushelper.py, daly.py and utils.py If you find any issues report it and revert to the last release again.
— Reply to this email directly, view it on GitHub https://github.com/Louisvdw/dbus-serialbattery/issues/86#issuecomment-1031822135, or unsubscribe https://github.com/notifications/unsubscribe-auth/AXRCL3JUUU47PNV2VZC2WH3U2AKVVANCNFSM5NERMJJQ. Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. You are receiving this because you were mentioned.
Hi Louis,
in the meantime I could test a little. In general the software still works after your modifications. The capacity value of the battery can be seen in the Venus console. But when I provoked a cell voltage high alarm (cell volt high level 2), no alarm was reported in the Venus console.
Here two screenshots at the same time of the alarm:
Regards, Thomas
Thomas + Nicole Krüger @.***
Am 07.02.2022 um 20:13 schrieb Louis Van Der Walt @.***>:
Hi Thomas I'm still busy adding more fixes and these new changes have not all been tested together so there might be some errors. If you want to give it a test before the next betais released then update from the latest main branch the following files: battery.py, dbushelper.py, daly.py and utils.py If you find any issues report it and revert to the last release again.
— Reply to this email directly, view it on GitHub https://github.com/Louisvdw/dbus-serialbattery/issues/86#issuecomment-1031822135, or unsubscribe https://github.com/notifications/unsubscribe-auth/AXRCL3JUUU47PNV2VZC2WH3U2AKVVANCNFSM5NERMJJQ. Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. You are receiving this because you were mentioned.
This is included in the new release v0.12 Note the cell voltages is disabled for now as it was giving issues
Is your feature request related to a problem? Please describe. The current driver is already really good! hank you for this and all the effort! But there are 4 things missing:
Describe the solution you'd like Display of the Alarms/Errors and the values
Additional context DALY 4S 12V 100A model R05A Raspberry Pi V2.73