Louisvdw / dbus-serialbattery

Battery Monitor driver for serial battery in VenusOS GX systems
MIT License
544 stars 147 forks source link

dbus-serialbattery driver causes Smartshunt not recognised after Venus restart #98

Closed smejfi closed 2 years ago

smejfi commented 2 years ago

Describe the bug When this driver is installed into Venus OS and instead of serial BMS I connect Victron Smartshunt witch VE direct to USB cable, it is recognized correctly, but after Venus restart, it is not recognized at all or it is loaded as some of the BMS from Dbus-serialbattery driver database with nonsense values. A few times I have also experienced that the Bluesolar MPPT which in my case is connected to GX with Ve direct to Ve direct cable, wasnt recognized after Venus restart, but this happened only very rarely and I dont know how to reproduce it.

To Reproduce Steps to reproduce the behavior:

  1. Instal dbus-serialbattery
  2. connect Victron Smartshunt
  3. Restart Venus os
  4. Smartshunt should not be recognized at all
  5. If you disconnect the smartshunt and connect it again, it is recognized correctly.

Expected behavior All devices should be recognized correctly after the venus os restart

Screenshots If applicable, add screenshots to help explain your problem.

VenusOS (please complete the following information):

Battery/BMS (please complete the following information):

Additional context

hcaldicott commented 2 years ago

I also have this issue.

VenusOS on a Rpi4. Serialbattery running with a JBD BMS. Seems the serial battery library stops my SmartSolar 100/30 from recognising correctly and it appears I cannot have both connected at once. If I reboot the device with only one of the two devices connected I can reliably tell to that device. However connecting both generally results in only the BMS being recognised.

gmanic commented 2 years ago

Same with venus os 2.82-large-30.

Removing the symlinks from /opt/victronenergy/(service(-template)?/)?dbus-serialbattery gets the smartshunt working again (but no JBD monitoring).

Might that be related to dbus-serialbattery just trying to get hold of any serial port, no matter what PRODUCT is connected? My MK3 USB-Adapter always works just fine (connecting the Multiplus).

I'm not nearly close to fully understand serial-starter's behaviour and prioritization, but would it be possible(helpful to limit dbus-serialbattery to non VEdirect devices? Then the smart shunt and other VEdirect connected devices would work while non-VEdirect devices would be subject to scanning by dbus-serialbattery?

hcaldicott commented 2 years ago

I actually use a multiport isolated UART (https://www.tindie.com/products/saimon/4-ports-isolated-usb-uart-converter-with-usb-c/) so for me all victron and JBD devices are on the same adapter. All ports appear as different serial devices though.

Even the ability to temporarily configure serialbattery to only listen on a named tty device would be adequate - leaving all others to detect per victron standards.

smejfi commented 2 years ago

Guys, I dont know if it helps to you, but for me the most of these issues were solved when I started using powered USB hub on my GX (even though I dont really need more than one USB device connected). Just try it and let me know if it helps.

Louisvdw commented 2 years ago

The serial battery driver is set up to be tested last after all other drivers have failed. So something is making the correct driver to be disconnected and then the serial battery picks up that a result is returned. So it is possible that the powered hub is giving anough power so that those devices never disconnect and so keep their original driver connected.

luphi01 commented 2 years ago

Same issue here, Smartshunt and BMS (Daly) are directly connected via USB, no Hub.

Louisvdw commented 2 years ago

There is a new beta4 release that should solve this issue. Please give it a test

Louisvdw commented 2 years ago

This is fixed in the new release v0.12

smejfi commented 2 years ago

Thank you Louis! I will start testing new release as soon as possible!

Best regards,

Filip ---------- Původní e-mail ---------- Od: Louis Van Der Walt @.> Komu: Louisvdw/dbus-serialbattery @.> Datum: 16. 6. 2022 10:30:42 Předmět: Re: [Louisvdw/dbus-serialbattery] dbus-serialbattery driver causes Smartshunt not recognised after Venus restart (Issue #98) "

This is fixed in the new release v0.12

— Reply to this email directly, view it on GitHub (https://github.com/Louisvdw/dbus-serialbattery/issues/98#issuecomment-1157384077) , or unsubscribe (https://github.com/notifications/unsubscribe-auth/AGAINTRLPVALYT67OVAWU6TVPLQ23ANCNFSM5PNHRAZA) . You are receiving this because you authored the thread. Message ID: < @.***> "