search

LoupVaillant / Monocypher

An easy to use, easy to deploy crypto library
https://monocypher.org
Other
580 stars 80 forks source link

doc/crypto_hchacha20: Fix typo. #235

Closed samuel-lucas6 closed 2 years ago

samuel-lucas6 commented 2 years ago

Please let me know if updating the copyright is unnecessary in this case.

samuel-lucas6 commented 2 years ago

Thanks for pointing that out. I proofread the entire documentation a while back but Loup did all the actual edits, so it's possible I reported this being wrong but nothing was changed. I've not seen 'iff' used before I don't think.

cfogelklou commented 2 years ago

Hi Samuel, I am not an official contributor or anything - Perhaps you should leave your PR open in case Loup decides it actually was a typo :). Best, CF.

LoupVaillant commented 2 years ago

Hi @samuel-lucas6, Thanks for the attempt.

I believe the "iff" was intentional, and did meant "if and only if". In this particular case, it’s really an equivalence: the buffer will be random if we have enough entropy in the seed, and will not be random if we don’t have enough entropy. I personally vote for keeping the "iff".