search

LoupVaillant / Monocypher

An easy to use, easy to deploy crypto library
https://monocypher.org
Other
614 stars 80 forks source link

fix include when using ED25519_SHA512 #95

Closed vbmithr closed 6 years ago

LoupVaillant commented 6 years ago

Just to confirm, is this because you get an incomplete type error when using the incremental signing interface?

vbmithr commented 6 years ago

No, I just can't compile without it. LANG=C gcc -Ioptional -DED25519_SHA512 -c optional/sha512.c monocypher.c does not work without my patch. Is there something wrong in the way I compile it?

LoupVaillant commented 6 years ago

Okay, but what is the error message, then?

I'm pretty sure you're doing things right, and that your patch does exactly the right thing. As it turned out, it's been some time since I have tested this option, and I do have an idea why your patch is now necessary. I just wanted to confirm my suspicions before I merge your patch (will do that before the end of the week). In any case, I will add a regression test to ensure the continued support of this compilation flag.

Oh, and thanks for the patch. I didn't notice the issue, so it really helps.

vbmithr commented 6 years ago

np :) Just try compiling the code with my command-line above and you will probably see an error, which is likely to be the same as what I have (missing definitions, blah blah… the error that happens when you forget to insert a .h file).

LoupVaillant commented 6 years ago

Oh, I was confused by the leading LANG=C. Anyway, I see the problem now. Accepting the PR right away, thanks.