search

LovesWorking / react-native-react-query-devtools

React Query Dev Tools for React Native
70 stars 5 forks source link

Upgrading peer dependencies (RN + RNSVG) #7

Open vsheyanov opened 3 weeks ago

vsheyanov commented 3 weeks ago

Is it possible (safe) to upgrade peer dependecies to:

"react-native": "~0.74.0",
"react-native-svg": "^15"

Right now the peer dependency is locked with previous versions of both packages. I did an override in package.json to suppress the error during npm i but I'm wondering if there is something that should be aware of.

Thank you!

GregPetropoulos commented 2 weeks ago

I am running expo 51 and having the same peer dep conflict. I tried patching by bringing the react-native dep up to version 74 and that failed.

I also tried using the resolution block in my root package.json and that failed. So no love from DevToolsBubble for RN devs I guess. 🙃

martinezguillaume commented 2 weeks ago

Me too, error on install with react-native dep :( no love for me

LovesWorking commented 2 weeks ago

Thanks for the report. Can you please make a PR for this change? @martinezguillaume @GregPetropoulos @vsheyanov If none of you can. I can try to make the change tonight.

GregPetropoulos commented 2 weeks ago

@LovesWorking I have WIP PR, can you allow me permission to push a branch up I am getting a 403

Screenshot 2024-07-09 at 11 08 59 AM
toppsdown commented 2 weeks ago

+1 for same problem

LovesWorking commented 2 weeks ago

@LovesWorking I have WIP PR, can you allow me permission to push a branch up I am getting a 403

Screenshot 2024-07-09 at 11 08 59 AM

Invite sent. Once accepted you should be able to make a pull request. Thank you!

GregPetropoulos commented 2 weeks ago

@LovesWorking I have WIP PR, can you allow me permission to push a branch up I am getting a 403

Screenshot 2024-07-09 at 11 08 59 AM

Invite sent. Once accepted you should be able to make a pull request. Thank you!

@LovesWorking I am not seeing an invite in my email, can you resend it? Nevermind I got it

LovesWorking commented 2 weeks ago

Is it possible (safe) to upgrade peer dependecies to:

"react-native": "~0.74.0",
"react-native-svg": "^15"

Right now the peer dependency is locked with previous versions of both packages. I did an override in package.json to suppress the error during npm i but I'm wondering if there is something that should be aware of.

Thank you!

Try version 1.2.0 and let me know if it all works. Thanks.

GregPetropoulos commented 2 weeks ago

TLDR; Can't have a div for React Native, we use Views.

@LovesWorking I appreciate your feedback. I don't see the correct changes in the lock file of the approved PR for the peerDeps merged, looks like someone poorly entered in the version number but that's a topic for another day.

The peerDeps don't have much to do with the bug I am getting and most likely went unnoticed for a while.

In fact, I dug deeper into the tanstack library and documentation I am pretty sure the ReactQueryDevtools is not supported for mobile devices. I haven't checked react-native-webview though.

In my screenshot on the left you can see the error I am getting in the simulator (I checked real devices as well). Also, deep in the node modules I circled the div causing the issue and in my expo go template app. On the right you can see the ReactQueryDevtools are turned on. 🤷‍♂️

Screenshot 2024-07-11 at 4 32 51 PM
martinezguillaume commented 2 weeks ago

Sorry for the confusion, here is the other pr to fix the deps

@GregPetropoulos yes react-query-devtools is not supported on react-native, for now you have to solution :

vsheyanov commented 2 days ago

@martinezguillaume thanks for the fix. Now it installs without any warnings, and works perfectly, but if we install the last 1.3.0 version, it pulls the whole expo dependency into our project, which is not optimal. Do you think it's worth a separate issue?

martinezguillaume commented 2 days ago

Like you want ! We can close this issue and reopen another one