Lovesan / bike

Common Lisp .Net Core Interop
MIT License
144 stars 5 forks source link

Some systems failed to build for Quicklisp dist #18

Open quicklisp opened 8 months ago

quicklisp commented 8 months ago

Building with SBCL 2.3.11.165-7fa632585 / ASDF 3.3.5 for quicklisp dist creation.

Trying to build commit id fb3fdfb35e5a44fea787f7ba6893b62bad05a827

bike-examples fails to build with the following error:

Unhandled METHOD-RESOLUTION-ERROR in thread #<SB-THREAD:THREAD tid=498994 "main thread" RUNNING {1040480133}>: 

bike-tests fails to build with the following error:

Unhandled METHOD-RESOLUTION-ERROR in thread #<SB-THREAD:THREAD tid=499083 "main thread" RUNNING {10017D8003}>: 

bike fails to build with the following error:

Unhandled METHOD-RESOLUTION-ERROR in thread #<SB-THREAD:THREAD tid=499101 "main thread" RUNNING {10017D8003}>: 

Full log here

Lovesan commented 5 months ago

@quicklisp I was unable to reproduce this. That .NET method exists, so it's kind of strange that the library does not see it. Also, I have not seen anything like this in CI. Maybe that's a .NET SDK installation issue? Please try upgrading to the latest SDK.

Lovesan commented 1 month ago

@quicklisp So, it seems like the method is indeed missing from older versions of .NET, namely from .NET 5

I've backported it to .NET 5 in the latest commit https://github.com/Lovesan/bike/commit/b532f8c96d94e058e1cab091552a3014503794e6

Should be ok now.

Lovesan commented 1 month ago

An SDK update should be necessary because .NET 5 is out of support now. Still, .NET 6+ has this FP issue on Linux. Maybe I'll incorporate the existing workaround into the library itself.