Lovinity / wwsu

THIS PROJECT HAS BEEN MIGRATED TO GITLAB: https://gitlab.com/wwsu1069/wwsu
4 stars 1 forks source link

Condition in manually edited timesheets could cause issues. #70

Closed Lovinity closed 4 years ago

Lovinity commented 5 years ago

Example scenario: A director is scheduled to be in 1pm-2pm and 4pm-6pm. The director does not add any timesheet logs until 5pm, at which they specify they actually arrived at WWSU at 1pm.

What ends up happening is that the single timesheet record will bypass one of the two scheduled hours (I don't know which one it will end up bypassing, but I know it will bypass one of them).

Add a check in the system for this. And when it happens, do like it does for active timesheets; clock-out and then immediately clock-in again with a new timesheet record corresponding to the next scheduled hours timeblock. That way, all scheduled hours are accounted for.

Also, make sure that this will work regardless of number of scheduled hours. For example, if the director for whatever reason had 4 scheduled hour blocks in between time, ensure it creates 4 separate timesheet records.

Lovinity commented 4 years ago

It works!