The old implementation of FluidTransferHelperImpl#toFluidVariantStorage doesn't check if the wrapped IFluidTransfer allows insertion/extraction. So does FluidTransferHelperImpl#toSingleFluidStackStorage. See the issue.
My rewrite doesn't use FluidTransferHelperImpl#toSingleFluidStackStorage. However, it's an inefficient implementation, because IFluidTransfer doesn't provide method that checks and permits or aborts insertion/extraction at a certain slot.
The old implementation of
FluidTransferHelperImpl#toFluidVariantStorage
doesn't check if the wrappedIFluidTransfer
allows insertion/extraction. So doesFluidTransferHelperImpl#toSingleFluidStackStorage
. See the issue.My rewrite doesn't use
FluidTransferHelperImpl#toSingleFluidStackStorage
. However, it's an inefficient implementation, becauseIFluidTransfer
doesn't provide method that checks and permits or aborts insertion/extraction at a certain slot.