Low-Drag-MC / LDLib-MultiLoader

GNU General Public License v3.0
12 stars 14 forks source link

Fix `FluidTransferHelperImpl#toFluidVariantStorage` Doesn't Check Whether Fluid Can Be Transferred #8

Closed Phoupraw closed 1 year ago

Phoupraw commented 1 year ago

The old implementation of FluidTransferHelperImpl#toFluidVariantStorage doesn't check if the wrapped IFluidTransfer allows insertion/extraction. So does FluidTransferHelperImpl#toSingleFluidStackStorage. See the issue.

My rewrite doesn't use FluidTransferHelperImpl#toSingleFluidStackStorage. However, it's an inefficient implementation, because IFluidTransfer doesn't provide method that checks and permits or aborts insertion/extraction at a certain slot.

Yefancy commented 1 year ago

I have rework the transfer api to fully support fabric api