search

Low-Drag-MC / Shimmer

A mod that integrates my passion for rendering
MIT License
67 stars 22 forks source link

Blooming parts of blocks do not take brightness into account #106

Open Firch opened 5 months ago

Firch commented 5 months ago

Minecraft Version

1.19.2 (potentially on higher versions too)

ModLoader

Forge

Shimmer version

Shimmer-forge-1.19.2-0.1.14

Modpack info or mod list(please reduce mod range)

-

The latest.log file and hs_err_pidXXX if exists

-

optifine , Rubidium , flywheel or any rendering related mods. mod version is required.

Embeddium-0.3.5

Issue description

Blooming parts of blocks don't take illumination into account. If it is too dark around the block that has blooming parts, it will stay dark with blooming applied into it. It wasn't noticed before because most players usually play with "Bright" brightness setting, where it doesn't alter the color as much (if it even alters colors at all), but with "Moody" (or close to that value) brightness setting it is very noticeable that blooming parts are not illuminated.

You can see our discussion about it in discord: https://discord.com/channels/980360897354682389/980361526600953856/1213598668922429490

How it looks with "Moody": изображение How it looks with "Bright": изображение gif Notice that when I turn on colored-lights setting blooming part stays unaffected by it. If not making it affected by coloring light it is probably better to make it emissive.

Steps to reproduce

1, Make block with blooming part

  1. Make sure that brightness setting is on low value (for ex. "Moody")
  2. Notice that blooming part is darkened by moody setting

Expected behavior: Blooming part is emissive, unaffected by brightness, unaffected by block (other light sources) illumination and environmental (daylight) illumination

Other information

No response

Firch commented 5 months ago

Seems like disabling "using light map" in config fixes this. Not sure if I should close the issue?