search

Low-Drag-MC / Shimmer

A mod that integrates my passion for rendering
MIT License
67 stars 22 forks source link

Colored Light Monitor is always enabled in dev environment #92

Closed AlexNijjar closed 7 months ago

AlexNijjar commented 7 months ago

I'm adding Shimmer compat to my mod, Ad Astra. I've added it to my dev environment; however, every time I launch the game, the colored light monitor overlay appears. I'm able to temporarily get rid of it by running the /shimmer coloredLightMonitor command. But this overlay will reappear every time I restart the game.

Looking at the code, it appears that this overlay is always enabled by default in the dev environment: https://github.com/Low-Drag-MC/Shimmer/blob/d513c3debfdb931e595d982a4802757a1f0088ff/Common/src/main/java/com/lowdragmc/shimmer/client/light/LightCounter.java#L85

This is fine for Shimmer development, but is problematic for any modder that adds Shimmer to their dev environment. It should either always be disabled by default, or be saved to a config somewhere so that I can close it once and not have to see it again.

Screenshot 2023-12-29 at 3 41 07 AM
Yefancy commented 7 months ago

image

do it anywhere in you dev project

AlexNijjar commented 7 months ago

Sorry, what does this mean? Are you saying that I should manually disable the monitor by setting LightCounter.Render.enable to false somewhere in my project?

Yefancy commented 7 months ago

Sorry, what does this mean? Are you saying that I should manually disable the monitor by setting LightCounter.Render.enable to false somewhere in my project?

yeah

in your dev

public init() {
    if (isDev() && isShimmerLoaded()) {
        LightCounter.Render.enable = false;
    }
}
Yefancy commented 7 months ago

btw, a really cool mod you have done