Shimmer 0.2.3 crashes when loading a world with Embeddium 0.3.0 installed

[DasTechniker]

Minecraft Version

1.20.1

ModLoader

Forge

Shimmer version

Shimmer-forge-1.20.1-0.2.3.jar

Modpack info or mod list(please reduce mod range)

Embeddium 0.3.0, Shimmer 0.2.3

The latest.log file and hs_err_pidXXX if exists

https://gist.github.com/DasTechniker/efb157deee6605b4b74aacb129a3393a

optifine , Rubidium , flywheel or any rendering related mods. mod version is required.

Embeddium 0.3.0

Issue description

Upon trying to load a world with both the latest version of Embeddium and Shimmer installed, the game crashes. That's all.

Steps to reproduce

1. Install both Embeddium 0.3.0 and Shimmer 0.2.3.
2. Boot up Minecraft. Note that the game itself loads just fine.
3. Attempt to load or create a world.
4. Observe mentioned behavior,

Other information

This was initially discovered in a modpack containing 274 mods, but was tested and verified to occur just between these two mods on their own.

[DasTechniker]

Issue persists as of Embeddium 0.3.1.

[DasTechniker]

Dug through the Embeddium source code, looks like encodeDrawParameters moved from CompactChunkVertex.java to VanillaLikeChunkVertex.java, so it should just be an easy fix? My experience with mixins is fairly limited.

[DasTechniker]

I do not know what I am doing

[Camawama]

Can confirm, this is happening on any version above Embeddium 0.2.18. I was about to make a report myself and then saw this. Thank you for that @DasTechniker 😅

[Yefancy]

tyvm, we are trying to fix it. not that really easy, embeddium changed a lot since 0.3.0

[Yefancy]

try 0.2.4

[DasTechniker]

0.2.4 loads, but the colored lights don't work on blocks in the world. Hand items will glow the correct color, and there's this weird ring of faint color around the block light. Using Spelunkery's glowstick to make it easier to see:

[DasTechniker]

Without Embeddium (for reference):

[Camawama]

https://github.com/embeddedt/embeddium/issues/215

[Camawama]

New update seems to have fixed crashing but the colored lighting is bugged.

Embeddium Version: 0.3.4 Shimmer Version: 0.2.4 Forge Version: 47.2.0

[Camawama]

Works while holding in hand though:

[Camawama]

[Camawama]

bump

[Camawama]

Performance Mods I have installed:

Embeddium Entity Culling FerriteCore ImmediatelyFast ModernFix Fastload Starlight AI Improvments Radium

[Camawama]

Disabled all those performance mods except for FerriteCore and Embeddium, same issue.

[DayTheMagpie]

Can vouch this is still happening on the latest versions. Visuals look exactly the same as the pics above, and bloom works inconsistently. Lava seems to be the only thing that keeps its bloom no matter what, no colored glow except the weird colored ring, but hand held and dropped items glow the correct color.

Embeddium: 0.3.9 Shimmer: 0.2.4 Forge: 47.2.0

[Camawama]

I also noticed that when colored_lights are enabled, I will get random severe FPS drops when looking in certain directions. (from like 350fps to 100fps)

[DasTechniker]

Bug is still occurring as of Forge 47.2.23, Embeddium 0.3.14.

[Camawama]

I was just going to hop in here and bump it again but looks like you had the same idea lol

Bug is still occurring as of Forge 47.2.23, Embeddium 0.3.14.

[Syclusion]

Mod seems abandoned sadly

[Camawama]

Mod seems abandoned sadly

Don't say that 😢