search

LowPowerLab / RFM69

RFM69 library for RFM69W, RFM69HW, RFM69CW, RFM69HCW (semtech SX1231, SX1231H)
GNU General Public License v3.0
780 stars 380 forks source link

Revert redundant pin numbering for ESP32 #185

Closed haschler closed 1 year ago

haschler commented 1 year ago

spi->begin() chooses VSPI pin numbering by default.

haschler commented 1 year ago

Just my two cents on this topic: Breaking the functionality for approx. 95% of ESP32 users just to support the special needs of perhaps 5% is not good... Removing the hardcoded pin numbers makes the library work on every ESP32 model/variant. You just have to wire the four SPI lines according to the pinout of your board (VSPI). The interrupt pin can be chosen freely (default is GPIO2) and passed to the constructor of RFM69 if needed.