search

LowTL / pe

0 stars 0 forks source link

[DG] Uninformative Sequence diagram #19

Open LowTL opened 5 months ago

LowTL commented 5 months ago

In the Add expenditure sequence diagram, the return values here are of type boolean, but this part of the sequence diagram does not make sense to me:

image.png

What does boolean mean? It is not immediately clear.

soc-se-bot commented 5 months ago

Team's Response

Boolean, as per CS1010 teaching materials, refer to true/ false. the naming of the methods also indicate that it is a boolean return type

We would not consider this as an unclear return statement.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: I do know what a boolean value is, and I do know that each isSomething(value) will return true or false. However, it does not tell me what happens when any of the boolean values are true or false.

Yes, it seems intuitive, but there can be multiple ways of handling the boolean return values that are not mentioned here. Perhaps there could be opt frames within this SD to show what happens if boolean is false, eg an error is thrown, and the function safely terminates.