search

LowellInstruments / Domino

Software - Unified Application for Data Logging Hardware from Lowell Instruments
GNU General Public License v3.0
6 stars 1 forks source link

Time/Clock Issues #76

Open Nickel33 opened 5 years ago

Nickel33 commented 5 years ago

STORY: As a user, I want to be sure that I start the logger with the correct time.

Details: There are several issues:

  1. The software is not highlighting the logger clock in yellow when it is more than 1 minute out of sync.
  2. The software is not warning the user with a pop-up window when the PC and logger clock are out is sync by more than 1 minute.
Nickel33 commented 5 years ago

No fixed for the case where the user adjusts the clock while Domino is open. To reproduce the error:

  1. Set your loggers clock to the correct time
  2. Close Domino.
  3. Manually adjust the PC clock to be 2 minutes off.
  4. Open Domino and observe that the time is highlighted.
  5. Set the logger's clock (highlighting disappears).
  6. Open PC clock settings and set clock back to correct time.
  7. Observe that the logger time is NOT highlighted and the logger can be started with no warning.
  8. Wait a few minutes and eventually the logger time will be highlighted, but by that time it is too late.

The fix is to compare the logger and PC time much more frequently so that the logger can't be started without a time check first.

Nickel33 commented 5 years ago

Check this issue on the Mac to be sure the logger time is flagged if the clock is out by more than 1 minute.

Nickel33 commented 5 years ago

Leaving open until Mac behavior is verified.

jeff101 commented 3 years ago

Interestingly Python seems to have fixed this issue internally. If I recall, previously the time would be loaded from the OS when the application started, but it wouldn't be updated if the user changed the time manually. It now works as expected on both Windows and Mac.