search

LtbLightning / bdk-flutter

Bitcoin Development Kit - Flutter Package
MIT License
63 stars 28 forks source link

Requirements for Stackmate to migrate to bdk-flutter #27

Closed i5hi closed 1 year ago

i5hi commented 1 year ago

hey!

Awesome work man!

We have been using bdk via ffi in our mobile wallet for nearly a year now and seeing the maturity of bdk-flutter we have decided to start the process of migration to minimise how many repos we have to maintain.

There are a few missing pieces that we need bdk-flutter to support for us to completely make the move.

The main requirements we have are

FWIU, only a single wallet is supported at the moment.

Looking at the api, I notice that there is a createWallet() function - which can internally create a label using bdk::wallet::wallet_name_from_descriptor and create the sqlite db accordingly. label will be returned as part of the response.

This label can then be used with wallet commands to support multiple wallets.

If multiple wallets are being supported, there should be an option to purge a wallet's sqlite db.

This should not be much, a new fn called sweepFunds can be created for this. This could be a good first issue for me to get the hang of the entire end to end FFI workflow.

If you have any documentation on this process, that would be really helpful or if you could give me a run down either here or if we can schedule a call over discord that would be even better. I will document the process so that new developers will find it easy to contribute.

A list of all our requirements are here but the above two are critical for us to migrate immediately.

https://github.com/StackmateNetwork/the-stackmate/issues/77

BullishNode commented 1 year ago

Support for multiple Bitcoin Wallets also a requirement for Bull Bitcoin, fyi

BitcoinZavior commented 1 year ago

@i5hi @BullishNode Thanks for the confidence and for the feature request.

Multiple wallet instances will be supported shortly, we should have a PR for this in a week or so.

Purge and sweep are good to have and can be done.

BitcoinZavior commented 1 year ago

https://github.com/LtbLightning/bdk-flutter/pull/39 addresses multiple wallets. Purge and Sweep have their own issue numbers #28 and #29

i5hi commented 1 year ago

Thanks @BitcoinZavior.

I just got email notifications of messages you have sent me over discord.

I am currently locked out of my discord since I do not have access to my 2fa device. I will be back on the 15th.