search

LtbLightning / bdk-flutter

Bitcoin Development Kit - Flutter Package
MIT License
60 stars 27 forks source link

rename native libs #78

Closed kumulynja closed 1 year ago

kumulynja commented 1 year ago

When importing different packages that depend on a native lib named 'librust', like bdk_flutter and ldk_node_flutter for example, it gives conflicts as described here: https://github.com/LtbLightning/ldk-node-flutter/issues/13.

This PR changes the name of the native libs that are build from 'librust' to 'libbdk' to have a specific name and avoid these conflicts with native libs of other packages that were build with Rust.

BitcoinZavior commented 1 year ago

Thanks, @kumulynja I think the binary should be called librust_bdk_ffi.so and librust_bdk_ffi.a for iOS Its a binary created from bdk ffi rust there is another rust project which is just bdk, I think it's better to use _bdk_ffi to indicate the correct source of the binary.

kumulynja commented 1 year ago

@BitcoinZavior Yes, you are right, that is way better naming. I just made the change already.