search

LtbLightning / bdk-rn

Bitcoin Development Kit - React Native Module
MIT License
50 stars 15 forks source link

Plan for secure storage #2

Closed jenkijo closed 2 years ago

jenkijo commented 2 years ago

Currently, bdk-rn only store plain data (seedphase, password,..) in localstorage that cause critical security issue. I glad to help you make change via PR, my plan is switch from localstorage to react-native-keychain, but what do you think about it?

If everything is clear, I will create a PR for it.

BitcoinZavior commented 2 years ago

@jenkijo thanks for the suggestion. Ideally the mnemonic or any other user wallet data should be secured by the app which will use bdk-rn. bdk-rn should only create the mnemonic and provide it to the app, its the app architecture which needs to account for secure storage.

The latest updates to bdk-rn remove async-storage dependency and do not store the mnemonic.

BitcoinZavior commented 2 years ago

@jenkijo I am closing this issue. You are welcome to look at other open issues to work on 😊