search

LtbLightning / bdk-rn

Bitcoin Development Kit - React Native Module
MIT License
50 stars 15 forks source link

Handle shp2wpkh type correctly in createDescriptor #27

Closed shobitb closed 2 years ago

shobitb commented 2 years ago

With the way the switch/case block is written in createDescriptor, the shp2wpkh and p2shp2wpkh cases result in a descriptor without a closing parenthesis e.g. sh(wpkh(...). This change is a refactoring of the switch case block to enable constructing descriptor for all cases correctly, and also improve maintainability and readability.

BitcoinZavior commented 2 years ago

@shobitb Thanks for the PR. please rebase with master and I will merge.

shobitb commented 2 years ago

Hi @BitcoinZavior I've resolved the conflicts. I did it via github (browser) so I think it created a new merge commit (not rebase). Is that okay?

BitcoinZavior commented 2 years ago

Yes that should do. I am just waiting for @rsbkme to try main branch before merge anything new.