LtxProgrammer / Changed-Minecraft-Mod

A Changed experience in the world of Minecraft.
MIT License
37 stars 38 forks source link

Xaero's Minimap has missing/broken icons #673

Open Y1rd opened 9 months ago

Y1rd commented 9 months ago

Milk Pudding doesn't have an icon, Hypno Cat is using a placeholder (?). I could be missing more, but these are the two I notice. image

LtxProgrammer commented 9 months ago

What am I supposed to do about this? This mod never had any compatibility set up for xaero's.

Y1rd commented 9 months ago

@LtxProgrammer , huh, well, you could just just make two textures in the assets folder. An example from from Fresh Animations Xaero's Icons image

Y1rd commented 9 months ago

Xaero's Minimap Modded Support would also be a good place to look at.

LtxProgrammer commented 9 months ago

I've realized how xaero's minimap does it, it uses getHead() of the entity's model. This does not include renderlayers for the model. Hypnocat's stripes are on a separate layer, and the puddle doesn't have a head.

LtxProgrammer commented 9 months ago

Nvm, reading the code. The render layers are being rendered, but not captured.

Y1rd commented 9 months ago

Just checked, the regular shark (that is latex for some reason) also doesn't have a icon.

spacedan228 commented 9 months ago

Just checked, the regular shark (that is latex for some reason) also doesn't have a icon.

i guess it mostly only works for humanoid entities

Y1rd commented 8 months ago

This is a little weirder now since eye rendering is separate, doesn't show any eyes for the icons. I guess making icons would be the best bet.