search

LuYiting0913 / pe

0 stars 0 forks source link

Edit task command cannot handle no-field-changed input #6

Open LuYiting0913 opened 1 year ago

LuYiting0913 commented 1 year ago

image.png

edit task with the exact same name and ddl. No error message. A legitimate user behavior is not handled

nus-pe-script commented 1 year ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Edit contact command cannot handle no-field-change exceptions

image.png

no error message for identical names /phones /address etc. A legitimate user behavior is not handled

[original: nus-cs2103-AY2223S1/pe-interim#4923] [original labels: type.FunctionalityBug severity.Low]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

This is considered user directly sabotaging the application since it is not a legitimate user behavior to edit the contact/task to remain the same. It also does not affect the user experience.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: I disagree that this is a duplicate. Although they are similar problems, they are independently-fixable since "we keep independently-fixable things as separate bugs,"

I believe EditContact and EditTask class and their respective parsers are completely separate classes and different, so they are not likely to be caused by the exact same defect.

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: This should no be considered user directly sabotaging the application.

Users can make mistakes when making small changes to the details, like the date and time of the task. the user should be notified if there's no change to the deadline. It may be frustrating to the user if the user thought he/she has updated the deadline but actually not (due to user mistakes).

but I think featureFlaw would be more appropriate for this bug, due to the lack of proper handling (either blocking or warning) for potentially invalid inputs.