LuYiting0913 / pe

0 stars 0 forks source link

add_contact and edit_contact cannot handle obviously wrong phone numbers #8

Open LuYiting0913 opened 1 year ago

LuYiting0913 commented 1 year ago

image.png

the UG mentioned phone number should be at least 3 digits and without an upper limit, but this feature is not Moreover, a legitimate user behavior is not handled

nus-pe-script commented 1 year ago

Team's Response

Problems caused by extreme user behaviors: If the problems can only happen in case of deliberate sabotage (e.g., user entered a 30-digit telephone number), in which case it should not be considered a bug.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: the problem here is not about an overflow but a lack of constraints and failure to detect invalid input. if say, a normal phone number is 8 digit, the user made some mistakes and input a 7-digit or 9-digit number without realizing it.

The feature is implemented to work in a certain way but it could have been implemented to work in a better way (from the end-user's point of view) without much additional effort. (only having one >3digits constraint on phone number is too simple)