search

Lua-cURL / Lua-cURLv3

Lua binding to libcurl
MIT License
275 stars 63 forks source link

Update CMakeLists.txt #172

Closed wushifeng closed 2 years ago

wushifeng commented 3 years ago

Cmake has error to compile, modify the content

coveralls commented 3 years ago

Coverage Status

Coverage decreased (-0.8%) to 62.358% when pulling b251bc2bb0102024567f98ab9da0297e474dc84a on wushifeng:patch-1 into 833e87c830bed05fe3910a33f573c202a48ba6d4 on Lua-cURL:master.

coveralls commented 3 years ago

Coverage Status

Coverage remained the same at 63.193% when pulling b251bc2bb0102024567f98ab9da0297e474dc84a on wushifeng:patch-1 into 833e87c830bed05fe3910a33f573c202a48ba6d4 on Lua-cURL:master.

cryi commented 3 years ago

Hi,

this is forcing compilation against LuaJIT. Merging this would broke any other build pipeline, so I am against merging this in current state. (E.g. I build plain Lua-cURL without need for JIT).

Ideal course of action would be to make LuaJIT and shared library compilation optional. Few optional flags should do the trick.

Another option is to use existing CMakeLists.txt as subproject and build it from parent CMakeLists.txt.

msva commented 2 years ago

by the way, I succesfully build it with luajit on Gentoo all that years :shrug: