Open lukego opened 7 years ago
hi you could just ask for commit access.
True. However as a contributor I am hoping to use the Fork and Pull model and this requires a maintainer to engage with me after I open a pull request and make sure the changes are moving the repo in the right direction. Is someone(s) taking that role on this repo?
Several people have that ability. Just do your thing and it will get handled. The main problem we faced early on was over protective handling of the repo, and thus nothing has happened. Make your changes, and make your pull request.
And keep in mind, Mike said in the beginning, all history will likely be lost once this test report is merged into something else, like the main LuaJIT repo. So, branching, and pull requests and the like are more of a personal style and cleanliness/safety thing than a strict requirement.
@Wiladams Groovy. So here is how I see myself cooperating with other testniks:
branchmarks
branch is to provide the test suite for CI. My job as maintainer is to pull improvements to the test suite but make sure they are compatible with the CI before I push them. The invariant is that branchmarks
always runs the code that is live on CI.branchmarks
branch).How does that sound?
(and yes I understand that we may need to completely replace the workflow in the future e.g. if this code is all moved into the luajit repo, etc, but we can deal with that when it happens.)
What's the current state of this repo?
Howdy! I am a first-time contributor with PR #9 and I have some questions: