search

LuaJIT / LuaJIT-test-cleanup

Cleanup Workspace for LuaJIT tests
46 stars 19 forks source link

Convert, split up and reorganize tests #4

Open ladc opened 8 years ago

ladc commented 8 years ago

Split up the tests in to many small tests, and convert them into the format required by the testing framework where applicable. Reorganize them into the new directory structure.

agentzh commented 8 years ago

Just a side note: I hope that the test files are not too fragmented. With the data driven approach I proposed in #5, we can organize multiple (related) test cases in a single test file while still having the capability of running each test case separately (like temporarily adding a special --- ONLY to the test block or case that we want to run alone).

agentzh commented 8 years ago

Just a note to myself: special care must be taken when modifying existing test Lua code (better not touch at all unless extremely necessary), since even some minor changes may make the bug that it exercises no longer reproducible. I think the data driven approach can make the changes we perform to the existing test code minimal.

ladc commented 8 years ago

May I clarify that the issues should be handled in order: first #2 and #3 must be addressed in order for #4 to be tackled in any meaningful way.

ladc commented 8 years ago

@Wiladams I've restored the original state of the repo since we agree it's better to push changes to our local forks and submit pull requests to the master (e.g. 4fc9f29). Hope that wasn't too rash!

Wiladams commented 8 years ago

That's alright.� It was a small enough change that it doesn't really matter, and it's got us moving in some direction.

So, we now know the process we want to follow is to have a branch or fork and do pull requests, even though we individually have write permissions.

Does this come with an approval process as well?� Like, at least one other maintainer needs to agree for the pull request to be accepted?

-- William

Date: Wed, 10 Feb 2016 12:54:52 -0800 From: notifications@github.com To: LuaJIT-test-cleanup@noreply.github.com CC: william_a_adams@msn.com Subject: Re: [LuaJIT-test-cleanup] Convert, split up and reorganize tests (#4)

@Wiladamshttps://github.com/Wiladams I've restored the original state of the repo since we agree it's better to push changes to our local forks and submit pull requests to the master. Hope that wasn't too rash!

� Reply to this email directly or view it on GitHubhttps://github.com/LuaJIT/LuaJIT-test-cleanup/issues/4#issuecomment-182578793.

Wiladams commented 8 years ago

Now that we're back to square zero. Is anyone going to check in anything of substance? Are we really going to wait until the whole test framework issue is resolved before we attempt to do anything?