search

LuaLS / LLS-Addons

Addons for use with Sumneko's Lua Language Server
https://github.com/LuaLS/lua-language-server
MIT License
63 stars 46 forks source link

Update CC-Tweaked #109

Closed checkraisefold closed 8 months ago

checkraisefold commented 9 months ago

The def files just got a huge refactor fixing a bunch of issues a few days ago and yet the commit being used is from 5 months ago still

carsakiller commented 9 months ago

That was me! However, I purposely did not update the addon because the refactor has changed all types to be namespaced (i.e. event → ccTweaked.os.event). Because this is such a large change that would require everyone to adjust all the types they use, I didn't want to just update it. These more major, breaking changes aren't really handled gracefully in the addon manager right now.

I was initially working on the new addon manager so that we can properly follow semver and improve upon the current addon manager. However, there have been issues with the new addon manager, and I've been stuck trying to choose how the new registry should work.

I have also been considering creating a new “CC:Tweaked v2” addon here to allow people to easily stay on the current version if they choose, but I am not really a fan of having multiple addons for different versions of an addon.

I'd be interested in hearing the opinions of those that use the addon, but I don't really have a way of contacting users to get their feedback.

carsakiller commented 8 months ago

I think I'll just merge this. The new addon manager is going to be a while and the longer this waits, the more the non-namespaced types get used.

checkraisefold commented 8 months ago

I think I'll just merge this. The new addon manager is going to be a while and the longer this waits, the more the non-namespaced types get used.

yeah I think the amount of projects this addon is used in isn't massive, especially because I had no idea the addons even existed after a year of using the language server since it seems like a poorly advertised feature a lot of projects just use the ancient vscode Computercraft extension