search

LuaLS / LLS-Addons

Addons for use with Sumneko's Lua Language Server
https://github.com/LuaLS/lua-language-server
MIT License
63 stars 46 forks source link

fixed config.json on RSIDEA #115

Closed KeilAwk closed 8 months ago

KeilAwk commented 8 months ago

fixed config.json on RSIDEA OMG the config.json shouldn't have comments when i tried to enable RSIDEA,the Addons maneger gave me a error. after i deleted config.json's comments,it works! so i start a pr again, sorry

KeilAwk commented 8 months ago

oh right,there is something wrong in my git fork you can ignore the changes in addons/RavenscriptIDEA/info.json and .gitmodules git submodule addons/RavenscriptIDEA/module need to fetch the lastest

carsakiller commented 8 months ago

Should be all good now. Make sure to update your fork before making changes to prevent those merge conflicts. You can also rebase your changes on the main branch to bring it back up to date (that's what I just did) 🙂

KeilAwk commented 8 months ago

thanks! and is that a bug?the addons maneger can't read json with comments.if not,i think we should tell these thing to addon developer

carsakiller commented 8 months ago

JSON does not support comments, they are invalid syntax. cJSON is able to parse them, but I don't believe it is used by the addon manager.

KeilAwk commented 8 months ago

yeah,but in some extra syntax it can be exist and make developer distressed so i write a note to let addons developer know it i didn't start a pr for this yet https://github.com/Leafx-code/LuaLS.github.io/tree/patch-1