LuaLS / lua-language-server

A language server that offers Lua language support - programmed in Lua
https://luals.github.io
MIT License
3.35k stars 320 forks source link

Find All References not working as expected #1225

Closed Lowenson closed 2 years ago

Lowenson commented 2 years ago

I have a multi-root workspace. Developing addons for WoW where each root folder is an addon. Each addon has library files that are identical and I then copy the files when edited.

I added the addon's lib folder to ´Lua.workspace.ignoreDir´ setting. Then added the main lib folder to Lua.workspace.library.

I expected this to make all references to the main library files.

If I click "Go to Definition" on a function call in the addon, it goes to the correct file and function. But if I on that function click "Find All References" if finds nothing. I seem to work only one way. If I go the the addon version of the file, "Find All References" will find references in that addon.

I expected to find all references in the whole workspace since I added the folder as library. Is this intended behavior? Is there a setting? Or is it a bug?

Renaming also doesn't work in these library files. Only within the current root folder.

sumneko commented 2 years ago

This is the expected behavior, which is controlled by the ---@meta at the top of the file.

Lowenson commented 2 years ago

Ok.. So how do I use the meta tag then? Is there a documentation for it somewhere?

On Sat, Jun 18, 2022, 08:17 最萌小汐 @.***> wrote:

This is the expected behavior, which is controlled by the @.*** at the top of the file.

— Reply to this email directly, view it on GitHub https://github.com/sumneko/lua-language-server/issues/1225#issuecomment-1159371649, or unsubscribe https://github.com/notifications/unsubscribe-auth/AZLDCNV44PGCJY3NU7DWBATVPVSX5ANCNFSM5ZEGT6AQ . You are receiving this because you authored the thread.Message ID: @.***>

sumneko commented 2 years ago

https://github.com/sumneko/lua-language-server/wiki/EmmyLua-Annotations#meta

Lowenson commented 2 years ago

Ok, thanks. Seem to be used to restrict intellisense. I needed the opposite. I guess I'll have to use search and replace instead when renaming.

On Sat, Jun 18, 2022, 19:38 最萌小汐 @.***> wrote:

https://github.com/sumneko/lua-language-server/wiki/EmmyLua-Annotations#meta

— Reply to this email directly, view it on GitHub https://github.com/sumneko/lua-language-server/issues/1225#issuecomment-1159521557, or unsubscribe https://github.com/notifications/unsubscribe-auth/AZLDCNUCOAYLGKI7VNXNI5TVPYCPXANCNFSM5ZEGT6AQ . You are receiving this because you authored the thread.Message ID: @.***>