search

LuaLS / lua-language-server

A language server that offers Lua language support - programmed in Lua
https://luals.github.io
MIT License
3.35k stars 318 forks source link

IntelliJ or Jetbrains support? #1770

Open Ismoh opened 1 year ago

Ismoh commented 1 year ago

Will there be IntelliJ or any other IDE support of Jetbrains?

sumneko commented 1 year ago

See https://microsoft.github.io/language-server-protocol/implementors/tools/

Ismoh commented 1 year ago

There is no IntelliJ or other Jetbrains IDE. Is this a no then on my question?

sumneko commented 1 year ago

This language server is based on LSP. The page aboved list the clients which supports LSP. If IntelliJ or other Jetbrains IDE dose not be listed in it, you can ask them for supporting LSP.

Is this a no then on my question?

AFAIK, there are some 3rd plugins to support LSPs in IDEA, such as https://github.com/ballerina-platform/lsp4intellij LSP will be supported native in Fleet, see https://www.jetbrains.com/fleet/#polyglot

CppCXY commented 1 year ago

I did related work and I've found that lsp4intellij itself doesn't work at all. after modifying the code a lot and trying, I found it performance unacceptable. I haven't made this project public, and I think it's basically unavailable unless intellij officially provides LSP. image

Frityet commented 1 year ago

heres a plugin that adds it

Lordfirespeed commented 1 year ago

JetBrains just announced native LSP support in 2023.2. A plugin for IntelliJ (and the entire JetBrains ecosystem) using this language server should not be much different to the VSCode equivalent plugin implementation.

CppCXY commented 1 year ago

JetBrains just announced native LSP support in 2023.2. A plugin for IntelliJ (and the entire JetBrains ecosystem) using this language server should not be much different to the VSCode equivalent plugin implementation.

see https://github.com/LuaLS/lua-language-server/issues/2195, intellij plugins with basic functionality have been developed, but Jetbrains only supports LSP in the IU version and the functionality of LSP itself is not yet perfect.

Lordfirespeed commented 1 year ago

Yes, I understand. I was posting out of relevance :)

CppCXY commented 1 year ago

An early preview version of the plugin is now available in 2023.2 beta IU version. see: https://plugins.jetbrains.com/plugin/22315-sumnekolua/versions/stable/365277

angelozerr commented 5 months ago

Please try https://github.com/redhat-developer/lsp4ij which is a free lsp support for Intellij

CppCXY commented 5 months ago

Please try https://github.com/redhat-developer/lsp4ij which is a free lsp support for Intellij

Ok, I will try later

CppCXY commented 5 months ago

Please try https://github.com/redhat-developer/lsp4ij which is a free lsp support for Intellij

I've tried LSP4IJ, but its hover feels a bit ugly. S}R 7`{~N5_JW(G7I~UNI$V

the following is using jetbrain support: ST0BI2%_ B$}C B3${%A(}K

And it's workspace/executeCommand execution will fail, so I still can't switch to LSP4IJ

angelozerr commented 5 months ago

've tried LSP4IJ, but its hover feels a bit ugly.

Indeed LSP4IJ doesn't support syntax coloration for code block, see https://github.com/redhat-developer/lsp4ij/issues/297 As we want to support the most IJ version, we cannot support if for now //cc @fbricon

And it's workspace/executeCommand execution will fail, so I still can't switch to LSP4IJ

Have you a stacktrace? If no please share your LSP trace https://github.com/redhat-developer/lsp4ij/blob/main/docs/UserGuide.md#lsp-console

CppCXY commented 5 months ago

Have you a stacktrace? If no please share your LSP trace https://github.com/redhat-developer/lsp4ij/blob/main/docs/UserGuide.md#lsp-console

Okay, I'll look at it tomorrow.

angelozerr commented 5 months ago

@CppCXY when you say fail,you mean that the workspace apply edit doesnt updtate correctly your files?

If it that I have fixed several bugs in 0.0.2 that we will release soon.

CppCXY commented 5 months ago

@CppCXY when you say fail,you mean that the workspace apply edit doesnt updtate correctly your files?

If it that I have fixed several bugs in 0.0.2 that we will release soon.

Okay I'll wait for your version 0.0.2

fbricon commented 5 months ago

@CppCXY please try a nightly build of 0.0.2 and open a ticket in https://github.com/redhat-developer/lsp4ij/issues if you still have some problems, with steps to reproduce