LuaLS / lua-language-server

A language server that offers Lua language support - programmed in Lua
https://luals.github.io
MIT License
3.35k stars 320 forks source link

Löve2d Image:replacePixels reporting wrong number of arguments #2392

Closed Trystanosaurus closed 1 year ago

Trystanosaurus commented 1 year ago

How are you using the lua-language-server?

Visual Studio Code Extension (sumneko.lua)

Which OS are you using?

Windows

What is the issue affecting?

Diagnostics/Syntax Checking

Expected Behaviour

This might not be the place for this issue, if not feel free to close.

With löve2d when using Image:replacePixels it's reporting wrong number of arguments if you just give one, as in the example on the love2d wiki. image:replacePixels(imagedata)

The syntax checker is expecting 3: "data", "slice" and "reloadmipmaps". However "slice" only needs to be given if applicable (which it isn't with a plain texture) and "reloadmipmaps" defaults to true if the existing image has mipmaps and false if not. I appreciate it may be out of the scope of this plugin to know if these conditions are true or not.

The website in the hover over is also linking to the wrong page, it should be https://love2d.org/wiki/(Image):replacePixels

Actual Behaviour

Currently putting in the exaple from the love2d wiki gives an error about the nubmer of arguments.

Reproduction steps

Additional Notes

No response

Log File

No response

carsakiller commented 1 year ago

Hello 👋. I'm going to transfer this to the love2d addon repository. Actually, looks like you can't transfer an issue between organizations in GitHub ☹️. Could you copy this issue over to LuaCATS/love2d and close this one?

Trystanosaurus commented 1 year ago

Done, this issue can be closed now.