search

LuaLS / lua-language-server

A language server that offers Lua language support - programmed in Lua
https://luals.github.io
MIT License
3.29k stars 305 forks source link

Cannot build 3.9.1 from the source code due to failing to update git submodules #2685

Closed toku-sa-n closed 3 months ago

toku-sa-n commented 4 months ago

How are you using the lua-language-server?

NeoVim

Which OS are you using?

Linux

What is the issue affecting?

Other

Expected Behaviour

Can build this project from the source code provided in the release page

Actual Behaviour

make.sh fails because of missing files resulting from the fail of git submodule update --init --recursive.

Reproduction steps

  1. Go to the release page
  2. Download the source code archived in the tar format
  3. Untar by tar xf lua-language-server-3.9.1.tar.gz
  4. cd lua-language-server-3.9.1 && ./make.sh
  5. The following error messages are printed 
    fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
/tmp/tmp.qX6g4u7QEE/lua-language-server-3.9.1/3rd/luamake /tmp/tmp.qX6g4u7QEE/lua-language-server-3.9.1
./make.sh: line 5: ./compile/install.sh: No such file or directory
./make.sh: line 6: ./compile/build.sh: No such file or directory
/tmp/tmp.qX6g4u7QEE/lua-language-server-3.9.1
./make.sh: line 9: 3rd/luamake/luamake: No such file or directory

Additional Notes

I found this bug when I was writing an ebuild script for my Gentoo system. I can run the language server by downloading the binary file. Thus, essentially this bug doesn't affect me, but I report it just in case.

Log File

No response

nospam2998 commented 3 months ago

Would it be possible to disable the release page for a project? If not, this issue seems practically unactionable, since what you've discovered is more of a bug in the GitHub service itself. Microsoft might call it incorrect assumptions, since they supposedly don't have bugs in their products.

Maybe you would wish to suggest a solution or close this bug report?

toku-sa-n commented 3 months ago

Thank you for the comment. I didn't expect this, but the problem didn't seem to be fixed without a few workarounds. Googling this problem suggested a SO question of the same problem with an answer saying "It's not possible." For this, I'm going to close this issue.