search

LuaLS / lua-language-server

A language server that offers Lua language support - programmed in Lua
https://luals.github.io
MIT License
3.35k stars 320 forks source link

Not using latest version of LuaCats/love2d submodule #2812

Closed LuisCarli closed 2 months ago

LuisCarli commented 2 months ago

Issue Description

The latest release of the lua-language-server is using a 10 month old version of the LuaCATS/love2d submodule, which is still on 11.4 version of the love2d api. The latest version of the LuaCATS/love2d is up to date with the 11.5 Love2d.

Maybe the 3rd party libs submodules are not being automatically updated during release?

Additional Notes

No response

carsakiller commented 2 months ago

Correct, the third party libraries have always been managed manually. Since the addon manager came around, there has been less reason for most (VS Code) users to use the included libraries. We also have plans to remove the built-in libraries once a better solution for installing addons is complete.

However, if you open a PR updating the love2d library in the language server, it can still be accepted.

LuisCarli commented 2 months ago

Thank you for the information and for the quick response! I'll start managing the third party library definitions through the addon manager or directly through the workspace.library

(The Lua language server and the ecosystem of LuaCats Annotations have been a game changer for me!)