search

LuaLS / lua-language-server

A language server that offers Lua language support - programmed in Lua
https://luals.github.io
MIT License
3.33k stars 316 forks source link

Support for dynamically changing workspaces #988

Closed ghost closed 2 years ago

ghost commented 2 years ago

Are there plans to support adding or removing workspaces dynamically? If so, how high is the priority?

sumneko commented 2 years ago

Yes, but the priority is not high. This feature rarely uses, hard to test, and I have been busy competing for Elden Lord recently.

vahreniSICKAG commented 2 years ago

Dear Sumneko, first of all, I would like to send you our appreciation for your great work with the Lua Language Server! We, at the SICK company, are using the LanguageServer for programming Sensor-Applications for our smart "AppSpace" sensors and integration machines. In this context, we are developing multiple so-called Lua "apps" which are virtually separated into different workspaces since we provide a dedicated communication mechanism that allows better app sandboxing. Hence, we would appreciate it a lot if there is the possibility to dynamically add new workspaces. Could we support you in implementing this, e.g. by testing the new feature?

sumneko commented 2 years ago

You can implement it by restarting the server or starting multiple server instances for now. I will go to look into it later, maybe this is easier than I think.

sumneko commented 2 years ago

Basic features have been completed, but there are currently some problems that cause memory leaks after removing a workspace. I don't intend to solve this problem in version 3.5.0, I plan to solve the reconstruction file manager in the subsequent version.