LuaLS / lua.tmbundle

TextMate support for Lua
MIT License
7 stars 5 forks source link

LDoc and LuaDoc support #10

Closed zm-cttae closed 1 year ago

zm-cttae commented 1 year ago
zm-cttae commented 1 year ago

@sumneko this is ready to go!

If you want to test it manually:

$ git clone https://github.com/lunarmodules/LDoc.git

Search for --[[ and -- @ to see working tags.

We can automate testing in this PR (or new PR?). See http://mathworks/MATLAB-Language-grammar@58ecf4f/package.json#L5-L9 for a demo.

sumneko commented 1 year ago

Thank you!

We can automate testing in this PR (or new PR?). See http://mathworks/MATLAB-Language-grammar@58ecf4f/package.json#L5-L9 for a demo.

You can make a new PR

sumneko commented 1 year ago

image

I did some tests and found some confics. I'd like to view these as comments.

sumneko commented 1 year ago

image Wrong color with inline comments

zm-cttae commented 1 year ago

I'd like to view these as comments.

Let's remove the summary feature - it was a stretch goal anyway tbh.

Wrong color with inline comments

This seems like a regression in block comment matching. It's likely that the block documentation tag is beginning too early and causing this. It should start from --[[\n\G (second line), not --[[\G.

sumneko commented 1 year ago

Could you please make a new PR to fix them?

zm-cttae commented 1 year ago

Yepyep and also tracking issue just to inform people.

zm-cttae commented 1 year ago

Have we validated the 2 regressions aren't present now? The first one has definitely been patched now (removed rule & grammar also valid).

sumneko commented 1 year ago

Have we validated the 2 regressions aren't present now? The first one has definitely been patched now (removed rule & grammar also valid).

I'll try it myself for a few days first