search

LuaLS / lua.tmbundle

TextMate support for Lua
MIT License
7 stars 5 forks source link

Fix #10 luadoc / ldoc regressions #11

Closed zm-cttae closed 1 year ago

zm-cttae commented 1 year ago

image

I did some tests and found some conflicts.
I'd like to view these as comments.

image

Wrong color with inline comments

Assigned to @zm-cttae. Fix regressions introduced in #10 in rules for summary & documentation blocks.

Hekili commented 1 year ago

I have an issue that might relate to this ticket.

With lua-grammar disabled:

image

With lua-grammar enabled:

image

In the latter, the comment formatting (italics, dark grey text) bleeds past the closing ]] for the multiline comment.

Moving the ]] to a new line does not resolve it.

image

Closing the multiline comment with --]] resolves it.

image

zm-cttae commented 1 year ago

I think the regex is unable to detect the boundary condition (closing block comment on this case) appropriately.

sumneko commented 1 year ago

image It can be closed with a single - , maybe it is just a simple typo

zm-cttae commented 1 year ago

Will make fix PR today :)

zm-cttae commented 1 year ago

Fix confirmed in #13 - please merge!