multi-line lua comments never ends, unless type in extra -

alexr00 commented 1 year ago

Type: Bug

when using multi-line comments in lua, everything behind the comment will be treated as comment despite the comment was closed off properly:

--[[ if foo then
    bar=nil
end ]]
bar = foo

the bar = foo line should not be consider as a part of the comment but somehow by changing it to:

--[[ if foo then
    bar=nil
end -]]
bar = foo

the bar = foo line was nolonger considered as a part of the comment

VS Code version: Code - Insiders 1.79.0-insider (2575777b9d3cdb865d61f9f1dfaac1fea9e1bde6, 2023-05-12T05:21:06.392Z) OS version: Windows_NT x64 10.0.19044 Modes: Sandboxed: Yes

System Info

|Item|Value| |---|---| |CPUs|Intel(R) Core(TM) i5-9300H CPU @ 2.40GHz (8 x 2400)| |GPU Status|2d_canvas: enabled
canvas_oop_rasterization: disabled_off
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: enabled
multiple_raster_threads: enabled_on
opengl: enabled_on
rasterization: enabled
raw_draw: disabled_off_ok
video_decode: enabled
video_encode: enabled
vulkan: disabled_off
webgl: enabled
webgl2: enabled
webgpu: enabled| |Load (avg)|undefined| |Memory (System)|7.85GB (1.39GB free)| |Process Argv|C:\\Users\\Name\\AppData\\Local\\Temp\\Rar$DIa8756.1081\\pickup_brakes_ceramic.jbeam --crash-reporter-id f2d3adf6-7801-406a-9822-4a02de2d55a3| |Screen Reader|no| |VM|0%|

Extensions (1)

Extension|Author (truncated)|Version ---|---|--- vscode-language-pack-zh-hans|MS-|1.78.2023051009

A/B Experiments

``` vsliv695:30137379 vsins829:30139715 vsliv368cf:30146710 vsreu685:30147344 python383:30185418 vspor879:30202332 vspor708:30202333 vspor363:30204092 vslsvsres303:30308271 pythontb:30258533 pythonptprofiler:30281269 vshan820:30294714 pythondataviewer:30285072 vscod805cf:30301675 bridge0708:30335490 bridge0723:30353136 cmake_vspar411:30581797 vsaa593cf:30376535 pythonvs932:30404738 cppdebug:30492333 vsclangdf:30492506 c4g48928:30535728 dsvsc012cf:30540253 pynewext54:30618038 pylantcb52:30590116 pyind779:30611226 pythonsymbol12:30651887 a9j8j154:30646983 showlangstatbar:30737417 azdwalk:30721579 pythonms35:30671666 pythonfmttext:30716741 pythoncmvfstr:30726892 fixhidewlkth:30724384 showsbindicator:30724477 pythongtdpath:30726887 ```

Originally from @Please-Pick-a-Name in https://github.com/microsoft/vscode/issues/182375

alexr00 commented 1 year ago

after accidental testing, if i were to do the multi-line comment like this, where theres nothing in front of it, it will color the code properly aswell (having - in front of it is also fine)

--[[ if foo then
    bar=nil
end 
]]
bar = foo

Originally from @Please-Pick-a-Name in https://github.com/microsoft/vscode/issues/182375#issuecomment-1548914966

sumneko commented 1 year ago

Will VSCode automatically applies the latest submission of this project?

alexr00 commented 1 year ago

I pull the changes from this repo into VS Code about once per month. If I know here are good changes that we want to pull in sooner I will pull the changes in sooner.

zm-cttae commented 1 year ago

Nice fix & appreciate the lateral thinking there

LuaLS / lua.tmbundle

multi-line lua comments never ends, unless type in extra - #16