LuaLS / lua.tmbundle

TextMate support for Lua
MIT License
7 stars 5 forks source link

Block comments are not formatted correctly #20

Closed doctr-oof closed 6 months ago

doctr-oof commented 7 months ago

Summary

GitHub Linguist recently started using this grammar in its latest release. Since then, it has come to my attention that block comments simply do not work as expected when viewing Lua files on GitHub. This makes it extremely difficult to review PRs that contain block comments. This is reproduceable by all members on my engineering team.

I am not familiar with creating or editing grammar files, so I cannot fix this myself with a pull request.

Specifics

Example(s)

Example 1: image

Example 2: image

lewri commented 7 months ago

It looks like block comments following this change can deal with ]]-- instead of --]]. Edit: For clarification I'm not saying one is more right over the other (Lua is designed to accept both) but the bottom line should be that both are handled correctly.

Examples: with --]] image

with ]]-- image

sumneko commented 6 months ago

Many thanks!