search

LuaLS / vscode-lua

Release lua-language-server for VSCode
https://github.com/LuaLS/lua-language-server
MIT License
179 stars 49 forks source link

Include LuaCATS library with a dependent extension #127

Open notpeter opened 11 months ago

notpeter commented 11 months ago

Hi,

I have a set of LuaCATS types for a proprietary SDK: https://github.com/notpeter/playdate-luacats/

I would like to create a simple VSCode extension which depends upon sumneko.lua and bundles those types. Is this possible?

If it is not currently possible, I believe vscode-lua could provide a public API for other extensions by adding additional functions to the object returned from the activate(context: vscode.ExtensionContext) function:

https://github.com/LuaLS/vscode-lua/blob/7b58d50b4ea5feb1a478e6b0c18194ca1d1192a1/client/src/extension.ts#L33-L37

See: VSCode extensions API Documentation.

This exported API could be something simple like library_add(path) so I can provide a path to a subdirectory in my extension bundle for my lua ---@meta files.

I would love to attempt this myself, but I'm still struggling setup a working extension development environment. See: https://github.com/LuaLS/vscode-lua/discussions/125.

Thanks again for creating a great extension.

carsakiller commented 10 months ago

The intention with addons is that the language server can support definitions like this so that you don't have to make your own VS Code extension and it can be used in other editors as well. You could configure your addon for "automatic" enabling using a config.json to make things a little easier.

You could also add this to LLS-Addons which can then be used by the addon manager in VS Code – however, reading their license makes me think that maybe they would not like that.

Currently, my concern is that managing addons and installing them is quickly turning into a full-blown package manager.