LuahJunYang / pe

0 stars 0 forks source link

Special characters (emojis) are allowed which is not a language/intended feature #2

Open LuahJunYang opened 11 months ago

LuahJunYang commented 11 months ago

image.png

image.png

Special characters are allowed for the translated word/word which is not an actual language.

nus-se-bot commented 11 months ago

Team's Response

image.png

We had intended it as such as we want to give users the freedom to dictate how they are to learn and what is best for them.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Gibberish is allowed

Gibberish (!@#$%^&) is allowed to be words in this application.

While I understand that there is no command input restriction, these are not words to begin with.

It should not be allowed in this application, which is meant for users to learn proper words.

Someone may have accidentally typed this !@#$% in, and presumed that this is an actual word when it isn't? This will hinder their progress of learning words.

Screenshot 2023-11-17 at 5.04.34 PM.png


[original: nus-cs2103-AY2324S1/pe-interim#1501] [original labels: type.FeatureFlaw severity.Medium]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Like you said we mentioned that there is no command input restriction in our UG. Our product is designed to allow users to make their own flash cards as convenient as possible. In this case, any restriction on input is redundant and will further hinder users' operations on adding and editing the flash cards. In contrast, our current design of allowing full customizability fits with our product scope and ensures users can successfully make the flash cards they want.

We regard symbols as legal input. For instance, as a lazy user, I may want to learn the German word "Ausrufezeichen", which means the exclamation mark in English. Our app allows the user to add the flash card with a simple command add w/Ausrufezeichen t/!. However, if disabling symbol input, user's efficiency will decline and more importantly, the restriction will cause significant harm as it hinders user's legal operation.

Moreover, our app has provided a remedy if users wrongly input a word: they can use delete command to delete the card or edit the card.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


## :question: Issue response Team chose [`response.Rejected`] - [x] I disagree **Reason for disagreement:** [replace this with your reason] There can be cases where special characters such as ! could be useful like you mentioned. However, I fail to see how emojis could ever be paired with any word or language to be learnt and disallowing adding of such a flash card would be an improvement in the user's efficiency over having them manually delete it only after they realise the mistake that they have made.
## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.VeryLow`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]