Allow passing of axios_config

gregpriday commented 2 years ago

Description

This PR is fairly simple. It just gives you the ability to pass extra axios_config in the options parameter. The

It Fixes https://github.com/LuanRT/google-this/issues/21 by allowing you to pass proxy servers.

import SocksProxyAgent from 'socks-proxy-agent';

const httpsAgent = new SocksProxyAgent.SocksProxyAgent(...);
const options = {
  page: 0,
  safe: false,
  additional_params: {
    hl: 'en'
  },
  axios_config: {
    timeout: 15000,
    proxy: false,
    httpsAgent: httpsAgent
  }
}

const response = await google.search('how do you scrape google results?', options);

It should support standard HTTPS proxies, too. I just generally use Socks5.

Type of change

Please delete options that are not relevant.

[x] New feature (non-breaking change which adds functionality)

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] I have checked my code and corrected any misspellings

gregpriday commented 2 years ago

If this looks good, I'll finish other items on the checklist. Adding tests and documentation. It's a minor change though.

LuanRT commented 2 years ago

Sweet! And yup I agree, you don't have to add tests for this particular change. Left a review.

Thanks again!

github-actions[bot] commented 1 year ago

This PR has been automatically marked as stale because it has not had recent activity. Remove the stale label or comment or this will be closed in 2 days

LuanRT / google-this