Closed MehekFatima closed 3 weeks ago
Hello, it's a good implementation overall. I've separated the router and routes into separated files, but the implementation it's the same.
I found a problem with the generate executable, due to some routing problem, here's a screenshot:
This made the tests field as well. Can you solve it?
Hi, thanks for the feedback!
I’ll work on resolving the routing issue by adjusting the base path in TanStack Router for the packaged Electron app. This should prevent navigation issues and get the tests passing again.
Hey @MehekFatima, I've solved the issue, thanks for yours contribution overall.
Implement TanStack Router with Opinionated Structure
Summary
This PR integrates TanStack Router into the React application, refactoring the routing implementation for improved maintainability and clarity.
Changes
Details
RootRoute
andHomeRoute
with configurations.routeTree
for route hierarchy management.AppRouter
to useRouterProvider
.Opinionated Structure
RootRoute
handles layout and navigation.createRoute()
.routeTree
withRootRoute.addChildren()
.RouterProvider
inAppRouter
.Steps to Add a New Route
../pages/
(e.g.,NewPage.tsx
).createRoute()
.routeTree
usingRootRoute.addChildren([...])
.RootRoute
navigation if needed.