LubosD / fatrat

FatRat Download/Upload Manager - http://fatrat.dolezel.info
GNU General Public License v3.0
49 stars 20 forks source link

show popup on torrent DL finish even when seeding is active #13

Closed dwatzke closed 9 years ago

dwatzke commented 9 years ago

Hi,

currently fatrat shows a popup about a finished transfer only when a transfer reaches the "completed" state - but in case of torrents, this means that user doesn't get informed about a finished transfer until the pre-set ratio of seeding is reached (if seeding is enabled). This kind of sucks and I think that there should be two popups - one when the content of a torrent is downloaded and another one when the seeding is finished.

Thanks!

dwatzke commented 9 years ago

Here's a patch that fixes this:

https://github.com/dwatzke/fatrat/commit/dabb6f05614f8d1726c8c5c772fbe2b2707d5e9a

dwatzke commented 9 years ago

By the way, there's a small defect when you apply the patch - fatrat shows the "download finished, starting upload now" message after startup for torrent transfers that are in the seeding mode. Maybe the status-change-notification-signals should be connected after the transfers are loaded and initialized at startup.

LubosD commented 9 years ago

Merged.