LubosD / fatrat

FatRat Download/Upload Manager - http://fatrat.dolezel.info
GNU General Public License v3.0
49 stars 20 forks source link

square brackets in URL encode improperly on save and load #20

Closed ScottDillman closed 9 years ago

ScottDillman commented 9 years ago

This causes a url with [] to be encoded and saved and then re-encoded on load so that the URL becomes invalid and you get a failed download.

so [test] becomes %5Btest%5D which becomes %255Btest%255D

My current workaround is to use change line 252 in CurlDownload.cpp to use url.url.toString() instead of url.url.toEncoded()

I didn't have time to research if this is the correct fix or not, but for now everything is working as needed.

LubosD commented 9 years ago

You are right, since the loading code doesn't urldecode the persisted URL.