Luc-S / Toon-HASS

HomeAssistant integration with Toon thermostat.
20 stars 12 forks source link

Screens are not scaled properly for Toon 2 #12

Open Luc-S opened 6 years ago

Luc-S commented 6 years ago

You need to use the isNxt variable to set different value for the screen element sizes and positions.

dennis071nl commented 6 years ago

Luc,

I'm busy making the adjustments regarding the new Toon, only thing is i'm not a real developer. Can you get in touch with me??

dennis071nl commented 6 years ago

Luc,

I'm busy making the adjustments regarding the new Toon, only thing is i'm not a real developer. Can you get in touch with me??

Luc-S commented 6 years ago

Hi Dennis, sure. What adjustments are you working on already?

I'm not sure which elements we need to change and sadly I'm not able to test any changes. What needs to be done, I guess, is to add the 'if isNxt' statement to all elements that are defined in the code and not scaled properly.

So if we start with the main screen, file 'HomeassistantScreen.qml' on line 193:

    //Top section
    Rectangle {
        id: sensorRect
        x: 30
        y: 15
        width: 740
        height: 100
        radius: 10
        color: "#e8e8e8"

To maintain the 30 pixels left and right we have for a new Toon 1024 - 60 = 964 pixels

    //Top section
    Rectangle {
        id: sensorRect
        x: 30
        y: 15
        width: isNxt ? 964 : 740
        height: 100
        radius: 10
        color: "#e8e8e8"

I don't know if you already tried something like this but I think we should start with this, keep it simple :)

dennis071nl commented 6 years ago

Luc,

I started to add in all the isNxt in both height and width, but i'm not suren how to continue from here... only got my production Toon...

Would it be possible to just replace the adjusted files and restart Toon??

Op do 15 nov. 2018 om 13:18 schreef Luc_S notifications@github.com:

Hi Dennis, sure. What adjustments are you working on already?

I'm not sure which elements we need to change and sadly I'm not able to test any changes. What needs to be done, I guess, is to add the 'if isNxt' statement to all elements that are defined in the code and not scaled properly.

So if we start with the main screen, file 'HomeassistantScreen.qml' on line 193:

//Top section
Rectangle {
    id: sensorRect
    x: 30
    y: 15
    width: 740
    height: 100
    radius: 10
    color: "#e8e8e8"

To maintain the 30 pixels left and right we have for a new Toon 1024 - 60 = 964 pixels

//Top section
Rectangle {
    id: sensorRect
    x: 30
    y: 15
    width: isNxt ? 964 : 740
    height: 100
    radius: 10
    color: "#e8e8e8"

I don't know if you already tried something like this but I think we should start with this, keep it simple :)

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/Luc-S/Toon-HASS/issues/12#issuecomment-439021366, or mute the thread https://github.com/notifications/unsubscribe-auth/ASbGoQKThE-5J22ofJr7KJkckR_iAq0Hks5uvVuqgaJpZM4W8RaF .

Luc-S commented 6 years ago

I'm not sure what you mean by 'production Toon' however you can indeed replace the qml file with your changed qml file. A restart is not needed, restarting the GUI services is enough, at least on the old Toon: killall qt-gui

I would start with something small and create a quick back-up of your original file, unless your are feeling lucky :) So rename your HomeassistantScreen.qml to HomeassistantScreen.qm_ for instance, and then create a new file called HomeassistantScreen.qml with the new code (or copy paste the new file to the correct folder using a file transfer application).

dennis071nl commented 6 years ago

`Luc,

ik heb de files aangepast maar ik zie geen verandering op mn Toon, zou je misschien eens willen meekijken??

˜dennis

Op do 15 nov. 2018 om 14:17 schreef Luc_S notifications@github.com:

I'm not sure what you mean by 'production Toon' however you can indeed replace the qml file with your changed qml file. A restart is not needed, restarting the GUI services is enough, at least on the old Toon: killall qt-gui

I would start with something small and create a quick back-up of your original file, unless your are feeling lucky :) So rename your HomeassistantScreen.qml to HomeassistantScreen.qm_ for instance, and then create a new file called HomeassistantScreen.qml with the new code (or copy paste the new file to the correct folder using a file transfer application).

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/Luc-S/Toon-HASS/issues/12#issuecomment-439036770, or mute the thread https://github.com/notifications/unsubscribe-auth/ASbGoe9Yhee2KDFltYwHagTWsaTGBmw3ks5uvWmFgaJpZM4W8RaF .

Luc-S commented 6 years ago

Hoi Dennis, ja hoor maar hoe doen we zoiets?

Ik zou beginnen met het controleren of de isNxt property beschikbaar is en ook de waarde heeft die we verwachten. Kun je regel 19 van HomeassistantApp.qml aanpassen zodat de isNxt waarde in de rode tekst bovenin het scherm weergegeven wordt?

property string message : ""

naar:

property string message : isNxt

dennis071nl commented 6 years ago

Check anders ff je berichten op domoticaforum...:)

Op vr 16 nov. 2018 14:13 schreef Luc_S <notifications@github.com:

Hoi Dennis, ja hoor maar hoe doen we zoiets?

Ik zou beginnen met het controleren of de isNxt property beschikbaar is en ook de waarde heeft die we verwachten. Kun je regel 19 van HomeassistantApp.qml aanpassen zodat de isNxt waarde in de rode tekst bovenin het scherm weergegeven wordt?

property string message : ""

naar:

property string message : isNxt

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/Luc-S/Toon-HASS/issues/12#issuecomment-439388919, or mute the thread https://github.com/notifications/unsubscribe-auth/ASbGoezUgT807g2GUWwOydYRNTraXuRlks5uvrnmgaJpZM4W8RaF .

X1pheR commented 4 years ago

Hi @dennis071nl , did you ever get this fixed?