LucHermitte / lh-brackets

LH's bracketing system for vim
Other
51 stars 2 forks source link

Redo insert with '.' broken #2

Closed galou closed 8 years ago

galou commented 8 years ago

Repeat last insertion (with '.' in normal mode) is broken when lh-brackets intervenes.

LucHermitte commented 8 years ago

I know. :(

Actually this is broken with all bracketing plugins since a few (minor) versions of vim -- NB lh-brackets did not support redo at that time.

A patch has been proposed to vim to help us define such mappings that can be redone. Last I checked (3-4 weeks ago), the patch hasn't been merged. I'll have to check again.

I leave the issue open in the mean time.

LucHermitte commented 8 years ago

redo shall now be handled since commit 3ef497fa204f581ceb24add5fb0a5e40710a6315 (branch repo-repeat)

Intensive testing will be conducted before a final merge of the branch.

galou commented 8 years ago

Great! Thanks! I'll test it.

LucHermitte commented 8 years ago

It should work correctly now. I may refactor the internal functions as <localleader>1 from lh-cpp doesn't work anymore. But at least this time, I will have non-regression tests. I close the issue.