LucaCappelletti94 / csv_trimming

Package python to remove common ugliness from a csv-like file
MIT License
87 stars 0 forks source link

Feedback after quick tests #2

Open Pierlou opened 2 months ago

Pierlou commented 2 months ago

Hi, thanks for this lib! It caught my interest because such cleaning methods could prove useful for an open data platform, such as data.gouv.fr. Quick feedback:

For the record, we are maintaining an other csv-related lib: csv-detective, maybe there will be nice cross-overs in the future 🤞

LucaCappelletti94 commented 2 months ago

Could you kindly provide a specific example of failure? Also, which version of Python are you using?

If you are using an old version of Python, you might have inadvertently installed an old version of this package, as it currently requires Python 3.9 exactly because the Pandas version it uses requires at least 3.9.

Pierlou commented 2 months ago

My env is in python 3.10 but I had pandas==1.5.3, which when simply using trimmer.trim() gave: AttributeError: 'DataFrame' object has no attribute 'map'. Updating pandas fix it as expected

LucaCappelletti94 commented 2 months ago

Restricted pandas version requirements in commit 3560d252df84a5d9d6a1d0a7d8719647406ba57f