search

LucaVazz / ScoreSaber-Rank-Panel

Twitch Extension, providing a Panel to show your current ranking on ScoreSaber.com.
5 stars 0 forks source link

SyntaxError: invalid regular expression flag s in scoresaber_lib.js:73:57 #2

Closed themoonisacheese closed 4 years ago

themoonisacheese commented 4 years ago

as per the doc, s is a valid flag, but it doesn't work on firefox 68.3.0 esr. you could try to pass it to a regex constructor as a separate argument.

maybe related: https://bugzilla.mozilla.org/show_bug.cgi?id=1579867

themoonisacheese commented 4 years ago

Apparently firefox just straight up doesn't implement dotAll. I have the same issue using edge, but I mean, edge.

LucaVazz commented 4 years ago

additional tracking: https://sentry.io/organizations/twitch-lv/issues/1096736262/?project=1482624

additional FF bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1361856

LucaVazz commented 4 years ago

Hey @themoonisacheese,

thank you for your report and the bugzilla link, that helped me investigate the problem.

From my side this issue seems to be fixed (tested in Firefox 71.0, Firefox Developer Edition 72.0b7, Firefox ESR 68.3.0).

The change will be published after the usual review from Twitch's side, so in about 3-5 days after I've got feedback on #1.

themoonisacheese commented 4 years ago

absolutely fantastic. feel free to close at your leisure.

LucaVazz commented 4 years ago

The new version was released yesterday. Marking the issue as closed, please comment if it re-appears on your side.