search

LucasAlegre / morl-baselines

Multi-Objective Reinforcement Learning algorithms implementations.
https://lucasalegre.github.io/morl-baselines
MIT License
271 stars 44 forks source link

Log all training parameters given to the algorithm #83

Closed wilrop closed 8 months ago

wilrop commented 8 months ago

I have added all training parameters to the config for multi-policy algorithms when logging is turned on. This ensures full transparency of the used parameters when logging results.

As a side note, I think this might also be a useful addition to the single-policy algorithms. However, these algorithms do not yet have a register_additional_config() method in the base class. I was unsure whether you would want this. If yes, let me know and I'll quickly extend this pull request to also log all single-policy parameters.

wilrop commented 8 months ago

That is exactly the reason why I did not yet do it. However, I recommend for the future to find a way to also log those parameters as otherwise people will be left wondering why they got certain results.