LucasBassetti / react-simple-chatbot

:speech_balloon: Easy way to create conversation chats
https://lucasbassetti.com.br/react-simple-chatbot/
MIT License
1.72k stars 596 forks source link

Lighthouse audit improvements #293

Open BranonConor opened 3 years ago

BranonConor commented 3 years ago

Hey there - huge fan of this package and wanted to make it better in a very small but mighty way. I'm using react-simple-chatbot in a work project and in doing Lighthouse Audits in Google Chrome nearing the end of the project, I noticed that there were some performance and accessibility issues flagged that were deep within the layers of the react-simple-chatbot package. Here are some of the suggestions that Google provided for the package:

Nothing crazy, BUT - in my project, the accessibility score is at 86. Removing this package in its current state bumps my score to a 97! So a pretty big jump. I know Lighthouse Audits aren't something to obsess over but these specific suggestions seemed both technically quite easy to fix and necessary from an accessibility standpoint (we are in the healthcare industry).

So I made the following changes:

I hope that is helpful and I hope my implementation is quality! I am new to styled components so hopefully I didn't mess that up. Thanks again for the awesome project and I'm looking forward to seeing if my contribution is worth merging.

Blessings, Branon

CharterXavi commented 3 years ago

Hey @LucasBassetti - do you still maintain this package? Looking forward to seeing if this pull request can help improve the accessibility of this package. Thanks man and cheers!

Branon

LucasBassetti commented 3 years ago

Hey guys. Sorry but I'm not able to give attention to this project at the moment. Is someone interesting in maintaining it?

BranonConor commented 3 years ago

@LucasBassetti no problem man I know you're probably quite busy! I'm very interested in maintaining it for you. Admittedly I'd need to do more digging around in the code to get a grasp on how you've built it but I'd be stoked to help out however you'd need it.