search

LucasFVoges / GRADA

simple GRep ADapter Analyser
MIT License
1 stars 0 forks source link

readlength is a problematic variable #9

Closed LucasFVoges closed 3 years ago

LucasFVoges commented 3 years ago

In the analyze_positions() function the readlength will genereate the matrix.

If the length of the reads is longer, the matrix will do what?

In the end it would nice to solve this by getting the maximum length during grada_analyze() !!!

LucasFVoges commented 3 years ago

will provide warning: "not matching the variable size" and does nothing bad! Will just loose the information beyond table size.

LucasFVoges commented 3 years ago

That is not completely true. if readlength = 3 and a position 5 is the only counted the result will be:

1 2 3 5 1 1 1 1

Because there is automatic deletion of one concurrence in the list for the range of readlength the results will be not wrong! And in the end this hole list will be written in the result table wich is not longer than readlength.

No Problem. A small Bug was fixed by only add poscount[1:readlength] to the table

LucasFVoges commented 3 years ago

This whole Poslist / Poscount procedure is to make a histogramm directly (So that not much space will be wasted by the positions) Thats because one accourance is alsways set in the beginning.

In the end this doesnt matter if in the plot function the same read lenght is chosen

LucasFVoges commented 3 years ago

AS LONG AS NO INFORMATION ABOUT READS ARE COLLECTED, THIS WILL STAY.

It is no bug anymore...